CFE Inline Integrity Checks: Difference between revisions

From CCMDB Wiki
Jump to navigation Jump to search
 
(7 intermediate revisions by 4 users not shown)
Line 5: Line 5:


== What sort of checks do we actually want? ==
== What sort of checks do we actually want? ==
{{Discuss | who = Pagasa |
Pagasa agreed that the most likely items to be changed that need to trigger a check are [[Service tmp entry]] and [[Boarding Loc]] and [[Transfer Ready DtTm tmp entry]] and [[Dispo DtTm]]s, and they need to be checked.
* This would best be based on things Pagasa is likely to check and change. Pagasa, so you agree that would most likely changes the following? Are there other checkable things you edit a lot? 
** [[Service tmp entry]] and [[Boarding Loc]] and [[Transfer Ready DtTm tmp entry]] and [[Dispo DtTm]]s  
}}


{{DJ |
* Possible checks:
* Possible checks:
** All S, B, T have to be before D
** All S, B, T have to be before D
** any T has to be after the B it's linked to
** any T has to be after the B it's linked to
*** how about T the same as B it's linked to?  see cases like this. should we allow? or T must increment one minute from B.  --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** how about T the same as B it's linked to?  see cases like this. should we allow? or T must increment one minute from B.  --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
**** Pulling that out for Lisa... [[User:Ttenbergen|Ttenbergen]] 15:56, 2022 August 10 (CDT)
** any S/B has to be before any CCI and ICD10, and D has to be after these
** any S/B has to be before any CCI and ICD10, and D has to be after these
* Pagasa, Julie, can you think of other things to check?  
* Pagasa, Julie, can you think of other things to check?  
** First S must be the same as first B.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** First S must be the same as first B.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** Agreed [[User:Ttenbergen|Ttenbergen]] 16:18, 2022 August 10 (CDT)
** Any CCI and ICD10 with datetime must have a corresponding B date.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** Any CCI and ICD10 with datetime must have a corresponding B date.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** Does it? They are acquireds so could be on B or at any time before D. If so, that was already on my list of possible checks above. If you mean something else, pls explain. [[User:Ttenbergen|Ttenbergen]] 16:18, 2022 August 10 (CDT)
** do we allow first B ER the same as second B non-ER when previous loc is ER?  or simply delete the first B ER from tmp if the same as second B non-ER. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** do we allow first B ER the same as second B non-ER when previous loc is ER?  or simply delete the first B ER from tmp if the same as second B non-ER. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** I don't understand this one. Do you mean same time? [[Query_check_tmp_service_or_location_duplicate]] should find such duplicates, so I think they are not allowed. Are you seeing such things? But I still don't remember what the additional information you give about ER has to do with it... can you explain? Additionally, these extra checks on this page are to catch things Pagasa accidentally gets wrong in edits - would she edit this? [[User:Ttenbergen|Ttenbergen]] 16:18, 2022 August 10 (CDT)
** only one T per B it's linked to (no multi T).  each T must have an integer.  found case with mutli T- one without integer and another with integer. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** only one T per B it's linked to (no multi T).  each T must have an integer.  found case with multi T- one without integer and another with integer. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** How old were the problems you found? [[Query_s_tmp_check_Boarding_Loc_and_TransferReadyDtTm_pairs]] should catch these. I can't think of an error scenario where Pagasa would edit the linking integers, so I wonder how this crept in. [[User:Ttenbergen|Ttenbergen]] 16:18, 2022 August 10 (CDT)
** T should not have missing time or should not have check mark.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** T should not have missing time or should not have check mark.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** Do you mean just time, or dttm? It's one field now, so missing time and midnight are the same. I don't think we have any rule to disallow that. [[User:Ttenbergen|Ttenbergen]] 16:18, 2022 August 10 (CDT)
}}


{{DL|
The checks could run at change time, or just before vetting.
* Julie says she is seeing some [[Transfer Ready DtTm tmp entry]] with same DtTm as their corresponding [[Boarding Loc]]. The way I read [[Transfer_Ready_DtTm_tmp_entry#Data_entry_instructions]] that should be impossible, ie becoming ready at the same time as arriving, no? [[query check_transfer_DtTm_during_admission]] would allow ''at'' BL but not before. Same for [[query check_Transfer_DtTm_after_paired_BL_and_before_later_BL]]. So right now we let BL equal to TR through, but we likely should not. Agree? [[User:Ttenbergen|Ttenbergen]] 15:56, 2022 August 10 (CDT)
}}


{{Discuss | who = Pagasa |
{{Todo
* Would running these queries just before vetting work for Pagasa? [[User:Ttenbergen|Ttenbergen]] 16:24, 2022 August 9 (CDT)
| who = Tina
}}
| todo_added = 2022-09-06
| todo_action = 2022-09-06
| question = _dev_CFE
* ready to implement inline cross check for CFE edits. [[User:Ttenbergen|Ttenbergen]] 10:03, 2022 September 6 (CDT) }}


== Related articles ==  
== Related articles ==  

Latest revision as of 10:03, 2022 September 6

Pagasa edits in CFE, and right now there are no checks in place for typos in these edits.

When and how would these checks run?

Cross-checks in CCMDB are triggered by collectors checking the various "complete" boxes, but there is no equivalent to this in CFE, especially since Pagasa can legitimately edit tables directly or via query, so these checks would likely need to be triggered manually, likely between Quality Assurance queries in CFE and actually setting records to "vetted".

What sort of checks do we actually want?

Pagasa agreed that the most likely items to be changed that need to trigger a check are Service tmp entry and Boarding Loc and Transfer Ready DtTm tmp entry and Dispo DtTms, and they need to be checked.

  • Possible checks:
    • All S, B, T have to be before D
    • any T has to be after the B it's linked to
      • how about T the same as B it's linked to? see cases like this. should we allow? or T must increment one minute from B. --JMojica 10:11, 2022 August 10 (CDT)
    • any S/B has to be before any CCI and ICD10, and D has to be after these
  • Pagasa, Julie, can you think of other things to check?
    • First S must be the same as first B. - --JMojica 10:11, 2022 August 10 (CDT)
    • Any CCI and ICD10 with datetime must have a corresponding B date. - --JMojica 10:11, 2022 August 10 (CDT)
    • do we allow first B ER the same as second B non-ER when previous loc is ER? or simply delete the first B ER from tmp if the same as second B non-ER. - --JMojica 10:11, 2022 August 10 (CDT)
    • only one T per B it's linked to (no multi T). each T must have an integer. found case with mutli T- one without integer and another with integer. - --JMojica 10:11, 2022 August 10 (CDT)
    • T should not have missing time or should not have check mark. - --JMojica 10:11, 2022 August 10 (CDT)

The checks could run at change time, or just before vetting.

_dev_CFE

  • ready to implement inline cross check for CFE edits. Ttenbergen 10:03, 2022 September 6 (CDT)
  • added: 2022-09-06
  • action: 2022-09-06
  • Cargo


  • Categories

Related articles

Related articles: