CFE Inline Integrity Checks: Difference between revisions

mNo edit summary
m Text replacement - "cross check " to "cross check "
 
(11 intermediate revisions by 4 users not shown)
Line 5: Line 5:


== What sort of checks do we actually want? ==
== What sort of checks do we actually want? ==
{{Discuss | who = Pagasa |
Pagasa agreed that the most likely items to be changed that need to trigger a check are [[Service tmp entry]] and [[Boarding Loc]] and [[Transfer Ready DtTm tmp entry]] and [[Dispo DtTm]]s, and they need to be checked.
* This would best be based on things Pagasa is likely to check and change. Pagasa, so you agree that would most likely changes the following? Are there other checkable things you edit a lot? 
** [[Service tmp entry]] and [[Boarding Loc]] and [[Transfer Ready DtTm tmp entry]] and [[Dispo DtTm]]s  
}}


{{Discuss |
* Possible checks:
* Possible checks:
** All S, B, T have to be before D
** All S, B, T have to be before D
** any T has to be after the B it's linked to
** any T has to be after the B it's linked to
*** how about T the same as B it's linked to?  see cases like this. should we allow? or T must increment one minute from B.  --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
*** how about T the same as B it's linked to?  see cases like this. should we allow? or T must increment one minute from B.  --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
**** Pulling that out for Lisa... [[User:Ttenbergen|Ttenbergen]] 15:56, 2022 August 10 (CDT)
** any S/B has to be before any CCI and ICD10, and D has to be after these
** any S/B has to be before any CCI and ICD10, and D has to be after these
* Pagasa, Julie, can you think of other things to check?  
* Pagasa, Julie, can you think of other things to check?  
Line 23: Line 18:
** only one T per B it's linked to (no multi T).  each T must have an integer.  found case with mutli T- one without integer and another with integer. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** only one T per B it's linked to (no multi T).  each T must have an integer.  found case with mutli T- one without integer and another with integer. - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** T should not have missing time or should not have check mark.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
** T should not have missing time or should not have check mark.  - --[[User:JMojica|JMojica]] 10:11, 2022 August 10 (CDT)
}}


{{DL|
The checks could run at change time, or just before vetting.
* Julie says she is seeing some [[Transfer Ready DtTm tmp entry]] with same DtTm as their corresponding [[Boarding Loc]]. The way I read [[Transfer_Ready_DtTm_tmp_entry#Data_entry_instructions]] that should be impossible, ie becoming ready at the same time as arriving, no? [[query check_transfer_DtTm_during_admission]] would allow ''at'' BL but not before. Same for [[query check_Transfer_DtTm_after_paired_BL_and_before_later_BL]]. So right now we let BL = TR through, but we likely should not. Agree? [[User:Ttenbergen|Ttenbergen]] 15:56, 2022 August 10 (CDT)
}}


{{Discuss | who = Pagasa |
{{Todo
* Would running these queries just before vetting work for Pagasa? [[User:Ttenbergen|Ttenbergen]] 16:24, 2022 August 9 (CDT)
| who = Tina
}}
| todo_added = 2022-09-06
| todo_action = 2022-09-06
| question = _dev_CFE
* ready to implement inline [[cross check]] for CFE edits. [[User:Ttenbergen|Ttenbergen]] 10:03, 2022 September 6 (CDT) }}


== Related articles ==  
== Related articles ==